Conversation
As per feedback in #16
lidel
changed the title
As per feedback in #18 (comment)
aschmahmann
reviewed
Jul 13, 2020
aschmahmann
reviewed
Jul 13, 2020
aschmahmann
reviewed
Jul 13, 2020
achingbrain
reviewed
Jul 13, 2020
jacobheun
reviewed
Jul 13, 2020
As per feedback in #19 (comment)
Co-authored-by: Jacob Heun <jacobheun@gmail.com>
Closed
lidel
changed the title
Member
Author
|
Thank you for feedback!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
movesRemoved as per Remove Pin.depth and add meta examples #19 (comment)depthfrom being a mandatory field to optionalmetaattributes.(as per feedback in Replace Pin.depth with Pin.mode string enum #16)
metafields, including peering hints to speed up transfer of data that is not already on the pinning service (closes Networking difficulties while pinning data #18, as per feedback in Networking difficulties while pinning data #18 (comment))cc @obo20 @achingbrain